Skip to content

feature: update cspr promotion banner #2016

feature: update cspr promotion banner

feature: update cspr promotion banner #2016

Triggered via pull request September 23, 2024 11:11
Status Success
Total duration 3m 18s
Artifacts

ci-check.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
build (18.x): src/apps/popup/pages/transfer/token-step.tsx#L64
React Hook useEffect has missing dependencies: 'selectedToken?.id' and 'setSelectedToken'. Either include them or remove the dependency array. If 'setSelectedToken' changes too often, find the parent component that defines it and wrap that definition in useCallback
build (18.x): src/apps/signature-request/router/index.ts#L2
Dependency cycle via @libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37=>@background/create-open-window:11
build (18.x): src/apps/signature-request/router/types.ts#L1
Dependency cycle via ./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37=>@background/create-open-window:11=>@signature-request/router:3
build (18.x): src/apps/signature-request/router/use-typed-location.ts#L3
Dependency cycle via @libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37=>@background/create-open-window:11=>@signature-request/router:3
build (18.x): src/apps/signature-request/router/use-typed-navigate.ts#L3
Dependency cycle via @libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37=>@background/create-open-window:11=>@signature-request/router:3
build (18.x): src/background/create-open-window.ts#L3
Dependency cycle via ./types:2=>@libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37
build (18.x): src/hooks/use-ledger.ts#L82
The 'makeSubmitLedgerAction' function makes the dependencies of useEffect Hook (at line 170) change on every render. To fix this, wrap the definition of 'makeSubmitLedgerAction' in its own useCallback() Hook
build (18.x): src/hooks/use-window-manager.ts#L4
Dependency cycle via @signature-request/router:3=>./types:2=>@libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37
build (18.x): src/libs/layout/error/content.tsx#L3
Dependency cycle via ./error:6=>./tab-page:22
build (18.x): src/libs/layout/error/error-boundary.tsx#L5
Dependency cycle via ./error:6