Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added an explanation why DynamicOpentracingHttpTracer has been disabled #5

Merged
merged 1 commit into from
Feb 28, 2020
Merged

added an explanation why DynamicOpentracingHttpTracer has been disabled #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/extensions/tracers/dynamic_ot/dynamic_opentracing_driver_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ TEST_F(DynamicOpenTracingDriverTest, formatErrorMessage) {
DynamicOpenTracingDriver::formatErrorMessage(error_code, "abc"));
}

// TODO (dmitri-d): memory leak is reported in this test
// Disabled due to heapcheck reporting false positives when the test is statically linked with libstdc++
// See https://github.com/envoyproxy/envoy/issues/7647 for the discussion
// TODO (dmitri-d) there currently isn't a way to resolve this: some tests will fail when libstdc++ is
// dynamically linked, this test fails when it's statically linked
TEST_F(DynamicOpenTracingDriverTest, DISABLED_InitializeDriver) {
{
std::string invalid_library = "abc123";
Expand All @@ -71,7 +74,10 @@ TEST_F(DynamicOpenTracingDriverTest, DISABLED_InitializeDriver) {
}
}

// TODO (dmitri-d): Fix "JSON supplied is not valid" error
// Disabled due to failing with "JSON supplied is not valid" error when the test is statically linked with libstdc++
// See https://github.com/envoyproxy/envoy/issues/7647 for the discussion
// TODO (dmitri-d) there currently isn't a way to resolve this: some tests will fail when libstdc++ is
// dynamically linked, this test fails when it's statically linked
TEST_F(DynamicOpenTracingDriverTest, DISABLED_FlushSpans) {
setupValidDriver();

Expand Down