Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bananapi-m2-zero spi only #308

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MSzturc
Copy link

@MSzturc MSzturc commented Dec 23, 2024

No description provided.

@KwadFan
Copy link
Member

KwadFan commented Jan 3, 2025

First of all, thank you for your contribution.
Could you please explain why are you inverting the logic and why you are using the logic for "SPI only" to enable UART?
Did you set the config right? Because, if you set

## BananaPi M2 Zero specific
### Disable OTG Serial Interface? (true/false)
[[ -n "$ARMBIAN_CONFIG_BPI2ZERO_OTG_SERIAL" ]] || ARMBIAN_CONFIG_BPI2ZERO_OTG_SERIAL="true"
[[ -n "$ARMBIAN_CONFIG_BPI2ZERO_ENABLE_UART3" ]] || ARMBIAN_CONFIG_BPI2ZERO_ENABLE_UART3="true"
[[ -n "$ARMBIAN_CONFIG_BPI2ZERO_ENABLE_SPI" ]] || ARMBIAN_CONFIG_BPI2ZERO_ENABLE_SPI="false"

it will trigger

echo "overlays=uart3" >> "${ARMBIAN_CONFIG_TXT_FILE}"

instead, which as I am not mistaken here is, what you try to archive.

Furthermore I want to point out that the BananaPI M2 will not be published, this is only for internal testing and was once created to help out the Desingner of "the100" which never got to a point to be "finished".
So, I am unsure if we need those changes and I will discuss this internally.

Regards Kwad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants