-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set browserify.tests only for addon tests #833
Conversation
Set browserify.tests only for addon tests
This is actually a fix for ember-cli 2.2. If you use the 2.2 and ember-simple-auth, the test runner will fail without this fix. Would you consider releasing this as a patch version? I have to pin simple-auth to this sha for my tests to work. |
1.1 will be released soon - for now please use this commit |
"soon" |
@robclancy: you're welcome to help and make "soon" even sooner… |
What by making a PR for this change back into 1.0.2? This is a VERY basic change and you just ignore the issue for your current stable release because 1.1 is coming "soon". |
Either by that or by helping us fix the issues that prevent us from releasing 1.1.0. Remember this is Open Source - nobody is paying anyone for it but everybody is welcome to contribute. |
So you need to get paid to merge this into stable and make a new stable release like literally every other open source project manages to do? |
@robclancy: Can you use the workaround on #832 in the meantime? |
I had to upgrade to a beta release for this. Then other things broke and then this issue was just ignored instead. I have in the past had to set npm to use a specific commit from this package due to stable being broken or having to use master but not wanting new breaking changes that will come up. There is now a pending task for us to remove this dependency since it is unreliable. |
See also https://github.com/mmelvin0/simple-auth-browserify-test and ember-cli/ember-cli#5231 for more info.
Closes #832