Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE 11 from browser targets #2565

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

gilest
Copy link
Contributor

@gilest gilest commented Jun 11, 2023

Removed IE 11 from test apps and "dummy" app which should resolve emberBabel.extends errors.

Possible fix for emberjs/ember.js#20458

IE 11 support was dropped in Ember 4.0

@gilest gilest changed the title Drop ie 11 from test app targets Drop IE11 from test app targets Jun 11, 2023
@gilest gilest changed the title Drop IE11 from test app targets Support ember v5 Jun 13, 2023
@BobrImperator
Copy link
Collaborator

Please change the PR title to something like "Remove IE11 from browser targets" or "Enable testing against Ember v5"

The browser targets change is not really targeting any users and I'd be hesitant saying that this enables Ember v5 support.

@BobrImperator BobrImperator mentioned this pull request Jun 23, 2023
@gilest gilest changed the title Support ember v5 Remove IE11 from browser targets Jun 23, 2023
@gilest gilest changed the title Remove IE11 from browser targets Remove IE 11 from browser targets Jun 23, 2023
@BobrImperator BobrImperator merged commit 6de61c3 into mainmatter:master Jun 23, 2023
57 of 66 checks passed
@BobrImperator
Copy link
Collaborator

Thanks for the PR!

@gilest gilest deleted the chore/drop-ie11-targets branch June 24, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants