Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix removed tests step from workflow #2556

Merged
merged 3 commits into from
May 10, 2023
Merged

chore(ci): fix removed tests step from workflow #2556

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a28297a
chore(ci): rename allowed to fail tests step
BobrImperator May 10, 2023
192d1fa
fix(ci): bring back test execution step
BobrImperator May 10, 2023
52020c4
chore(ci): stop using ::set-output"
BobrImperator May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3
id: yarn-cache
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3
id: yarn-cache
Expand All @@ -91,6 +91,9 @@ jobs:
- name: install dependencies
run: yarn install

- name: tests
run: yarn workspace ${{ matrix.workspace }} ${{ matrix.test-suite }}
continue-on-error: ${{ matrix.allow-failure }}

allow-fail-try-scenarios:
name: ${{ matrix.workspace }} ${{ matrix.test-suite }} - Allowed to fail
Expand All @@ -116,7 +119,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3
id: yarn-cache
Expand All @@ -129,15 +132,15 @@ jobs:
- name: install dependencies
run: yarn install

- name: tests
id: tests
- name: Allowed to fail tests
id: allowed_to_fail_tests
run: yarn workspace ${{ matrix.workspace }} ${{ matrix.test-suite }}
continue-on-error: true

- uses: mainmatter/continue-on-error-comment@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
outcome: ${{ steps.tests.outcome }}
outcome: ${{ steps.allowed_to_fail_tests.outcome }}
test-id: ${{ matrix.workspace }} ${{ matrix.test-suite }}

extra-tests:
Expand All @@ -158,7 +161,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3
id: yarn-cache
Expand Down Expand Up @@ -186,7 +189,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3
id: yarn-cache
Expand Down