Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated mixins in favor of session service #2480

Merged
merged 5 commits into from
Nov 4, 2022

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Nov 4, 2022

  • Removes DataAdapterMixin, ApplicationRouteMixin, AuthenticatedRouteMixin, UnauthenticatedRouteMixin, OAuth2ImplicitGrantCallbackRouteMixin
  • Refactors classic-test-app to use session service
  • Configures ESA for classic-test-app in ember-cli-build to get rid of automatic session initialization deprecation
  • Modifies documentation to no longer link to mixins

Migration Path:
https://github.com/mainmatter/ember-simple-auth/blob/master/guides/upgrade-to-v4.md
https://github.com/mainmatter/ember-simple-auth#walkthrough

@BobrImperator BobrImperator requested a review from a team November 4, 2022 12:38
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙌

@BobrImperator BobrImperator merged commit ff2636b into mainmatter:master Nov 4, 2022
@BobrImperator BobrImperator deleted the remove-mixins branch November 4, 2022 13:05
@BobrImperator
Copy link
Collaborator Author

@snewcomer already did some of the work before back when we were blocked by other dependencies.
I forgot about this and noticed only now when all of the mixins got removed moments ago 😓
Sorry!

#2339
#2337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants