-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2314] Add setup method in session service #2318
[2314] Add setup method in session service #2318
Conversation
e321445
to
828d22c
Compare
a56109a
to
156bf65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I think we should do a few more things though:
- in all public methods of the
session
service, we should assert thatsetup
has been called so that people that forget to do it get better feedback - use this new option in the test app
- strip the initializer from the app build completely if the new option is set
packages/ember-simple-auth/addon/initializers/setup-session-restoration.js
Show resolved
Hide resolved
156bf65
to
f4bc0a4
Compare
cddfd74
to
687a94b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
packages/ember-simple-auth/tests/unit/initializers/setup-session-restoration-test.js
Outdated
Show resolved
Hide resolved
687a94b
to
c59400e
Compare
packages/ember-simple-auth/tests/unit/initializers/setup-session-restoration-test.js
Outdated
Show resolved
Hide resolved
packages/ember-simple-auth/addon/initializers/setup-session-restoration.js
Show resolved
Hide resolved
dbe2f7e
to
416703f
Compare
416703f
to
6d86aad
Compare
6d86aad
to
c787059
Compare
This PR also introduces 3 new deprecations (aside from the intended
|
Should there be a link to the upgrade guide in the README? |
@steveszc Thanks, will try to work out better documentation for this |
closes #2314
closes #1854, and closes #2279
useSessionSetupMethod
'run time' configuration forsetup-session-restoration
intiializer to return earlyguides/upgrate-to-v4.md
.I was able to successfully confirm this working in my private project which conveniently is written in typescript #1854, #2279.