Update data-adapter-mixin.js #1297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
requested changes
Apr 25, 2017
There was a problem hiding this comment.
Hm, I think we should actually mention that headersForRequest will be used when the ds-improved-ajax feature is enabled.
|
@marcoow you mean specifically pointing to emberjs/data#3099 and not only to emberjs/rfcs#171 ? |
|
@bartocc: sorry for the delay - I meant linking to the feature flag: https://github.com/emberjs/data/blob/master/FEATURES.md#feature-flags |
|
updated @marcoow |
marcoow
approved these changes
Jun 7, 2017
|
Argh, I messed up rebasing… Can you rebase on |
|
I've lost the commits ... and since I edited them on GH, I don't have the in a local repo. Would you have a previous SHA by any chance ? |
|
Sorry for that - created a replacement: #1366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect docs about headersForRequest being used for ember-data versions >= 2.7.
This is on hold until emberjs/rfcs#171 gets resolved