Commits on Sep 13, 2016

1. Add explanatory comment to application route …

   The setup-session-restoration initializer needs the application route to be explicitly defined in the consuming app, so simple auth must ship with this file in case the consuming app hasn't defined their own. However, if the consuming app has another addon that also provides an application route via it's app folder, simple auth may override that addon's file with this one, depending on the load order.
   
   This is easily fixed by specifying an explicit load order (i.e. `after: 'ember-simple-auth'`). However, because the contents of this file are completely generic, and Ember's build process merges this file into the app folder without retaining source information, it's difficult to know from the consuming app's perspective that simple-auth is the addon providing this generic file (and therefore the `after` option needs to specify "ember-simple-auth").
   
   This adds an explanatory comment, hopefully making it a bit clearer in case anyone is trying to figure out where this empty application route file is coming from.

   

   davewasmer committed Sep 13, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 489e0e6
   • Browse repository at this point

   Copy the full SHA

   489e0e6 View commit details

   Browse the repository at this point in the history