Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send client_id in authentication requestion for OAuth2 Password Grant #503

Closed
bbooth opened this issue Apr 24, 2015 · 6 comments
Closed

Comments

@bbooth
Copy link
Contributor

bbooth commented Apr 24, 2015

My Authorization server requires me to send a client id. Can we make this an option in the config.

@marcoow
Copy link
Member

marcoow commented Apr 24, 2015

Adding a config option for client_id should be fine. Want to submit a pull request?

@bbooth
Copy link
Contributor Author

bbooth commented Apr 24, 2015

Yeah I have been trying to put something together, but I can't seem to get end to end testing working. I have tried to bower link my fork and then bower link ember-simple-auth to test my changes, but ember-cli does not like that. End up getting a nasty stacktrace about Invalid Version: * (which I think is how bower sets it after linking). How do you typically test this stuff out?

@marcoow
Copy link
Member

marcoow commented Apr 28, 2015

Ember Simple Auth's bower package is currently in an external repository which makes testing non-released versions a little hard. While that needs to be fixed, for now you can simply use the examples included in the repository which will use your local code.

bbooth added a commit to bbooth/ember-simple-auth that referenced this issue Apr 28, 2015
bbooth added a commit to bbooth/ember-simple-auth that referenced this issue Apr 29, 2015
@csprocket777
Copy link

I JUST ran into this with a new project. Is this available yet somewhere?

@bbooth
Copy link
Contributor Author

bbooth commented Apr 30, 2015

Currently have a pull request under review. #508

bbooth added a commit to bbooth/ember-simple-auth that referenced this issue Jul 14, 2015
bbooth added a commit to bbooth/ember-simple-auth that referenced this issue Jul 14, 2015
bbooth added a commit to bbooth/ember-simple-auth that referenced this issue Jul 16, 2015
bbooth added a commit to bbooth/ember-simple-auth that referenced this issue Jul 29, 2015
bbooth added a commit to bbooth/ember-simple-auth that referenced this issue Jul 29, 2015
marcoow added a commit that referenced this issue Jul 29, 2015
Issue #503 - Add optional client_id to OAuth2
@marcoow
Copy link
Member

marcoow commented Oct 16, 2015

1.0 has been released with this feature

@marcoow marcoow closed this as completed Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants