Deprecate opening a modal from string #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCutOfficial
force-pushed
the
step-1-deprecate-modal-from-string
branch
3 times, most recently
from
9a3cbc1 to
3ac5819
Compare
…deprecation test for embroider-optimized
BlueCutOfficial
force-pushed
the
step-1-deprecate-modal-from-string
branch
from
3ac5819 to
2fcc1e3
Compare
BlueCutOfficial
force-pushed
the
step-1-deprecate-modal-from-string
branch
from
2fcc1e3 to
fc69419
Compare
Mikek2252
approved these changes
Jan 31, 2024
BlueCutOfficial
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 1 to convert ember-promise-modals to a v2 addon.
In Embroider, it will no longer be possible to pass components by string, as explained in the Replacing Component Helper guide. Only passing a class will be allowed.
This PR deprecates the possibility of passing a component as string to the modal: