Add the ability to analyse nested translation folders #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCutOfficial
approved these changes
Feb 7, 2025
BobrImperator
approved these changes
Feb 7, 2025
beerinho
force-pushed
the
dbeer/442-nested-translations
branch
from
92eb627 to
1c7e43f
Compare
beerinho
force-pushed
the
dbeer/442-nested-translations
branch
from
1c7e43f to
af950f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #442, there was an issue where nested translations were being falsely shown as unused translations. This PR adapts the check to make sure the folders are incorporated into the check when
wrapTranslationsWithNamespaceis set totruein the configCloses #442