chore!: convert addon to v2 format #747
Conversation
| @@ -12,7 +12,16 @@ | |||
| "lint:test-app": "yarn workspace test-app run lint", | |||
| "lint:fix": "npm-run-all --aggregate-output --continue-on-error --parallel lint:fix:*", | |||
| "lint:fix:addon": "yarn workspace ember-cookies run lint:fix", | |||
| "lint:fix:test-app": "yarn workspace test-app run lint:fix" | |||
| "lint:fix:test-app": "yarn workspace test-app run lint:fix", | |||
| "prepare": "yarn workspace ember-cookies run build", | |||
There was a problem hiding this comment.
this is needed to build the addon as v2 addon needs to be prebuilt before consumption
| @@ -1,9 +0,0 @@ | |||
| const { buildEmberPlugins } = require('ember-cli-babel'); | |||
There was a problem hiding this comment.
this is not needed as we now provide babel.config.json
| # ember-try | ||
| .node_modules.ember-try/ | ||
| package.json.ember-try | ||
| # .md copies from release |
There was a problem hiding this comment.
to make those files explorable on github, we keep them in the root folder.
to make those files packed at publish time, we copy them to the addon folder.
This allows to keep single source of truth and at the same time keep all the nice parts of DX
| "scripts": { | ||
| "build": "rollup --config", | ||
| "copyDoc": "cp ../../*.md .", |
There was a problem hiding this comment.
this is where copy of the files happens.
|
@marcoow as a followup and to ease release process, I can open PR to introduce this really simplifies release management for v2 addons as otherwise it might be error prune as it needs to consist of at least:
|
packages/ember-cookies/.gitignore
Outdated
| package.json.ember-try | ||
| # .md copies from release | ||
| /CHANGELOG.md | ||
| /README.md |
| ["@babel/plugin-proposal-decorators", { "legacy": true }], | ||
| "@babel/plugin-proposal-class-properties" | ||
| ] | ||
| } |
marcoow
force-pushed
the
v2-addon
branch
2 times, most recently
from
43b409d to
8821903
Compare
This is breaking change as it now requires the consuming addon or the add to have ember-auto-import >= v2
This is breaking change as it now requires the consuming addon or the add to have ember-auto-import >= v2.
This follows https://github.com/embroider-build/embroider/blob/main/PORTING-ADDONS-TO-V2.md#part-4-convert-addon-to-v2 guide