Remove "ember-lodash" dependency #22
Conversation
|
Travis failure seems unrelated |
| @@ -116,31 +114,34 @@ export default Ember.Service.extend({ | |||
| _filterCachedFastBootCookies(fastBootCookiesCache) { | |||
| let { hostname, path: requestPath, protocol } = this.get('_fastBoot.request'); | |||
|
|
|||
| return _collection.reduce(fastBootCookiesCache, (acc, cookie, name) => { | |||
There was a problem hiding this comment.
return Ember.A(_collection).reduce(…
should work here as well, using for … in with continue feels much worse than using reduce.
There was a problem hiding this comment.
return Ember.A(_collection).reduce(… doesn't work because we're iterating over fastBootCookiesCache, not _collection. return Ember.A(fastBootCookiesCache).reduce(… however also doesn't work because fastBootCookiesCache is an object, not an array. it seems that the only reason for using lodash here was that lodash can iterate over the key-value pairs of an object directly, but I don't think that's worth the big dependency if a simple for-in loop can do the same.
There was a problem hiding this comment.
Ah right. I guess we could keys(fastBootCookiesCache).reduce(… then though.
There was a problem hiding this comment.
yes, that seems to work too. I've updated the PR with that suggestion.
|
🎉 |
This PR removes the
ember-lodashdependency. Importing all of lodash just for these two functions seems a bit wasteful to me unless you're already using it anyway.