support cookies with "=" in the value (#201)

mainmatter · Mar 8, 2019 · e5234f6 · e5234f6
1 parent fc8d683
commit e5234f6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/addon/services/cookies.js b/addon/services/cookies.js
@@ -205,7 +205,10 @@ export default Service.extend({
   },
 
   _filterDocumentCookies(unfilteredCookies) {
-    return unfilteredCookies.map((c) => c.split('='))
+    return unfilteredCookies.map((c) => {
+      let separatorIndex = c.indexOf('=');
+      return [c.substring(0, separatorIndex), c.substring(separatorIndex + 1)];
+    })
       .filter((c) => c.length === 2 && isPresent(c[0]));
   },
 

diff --git a/tests/unit/services/cookies-test.js b/tests/unit/services/cookies-test.js
@@ -214,6 +214,14 @@ describe('CookiesService', function() {
 
         expect(this.subject().read(COOKIE_NAME)).to.eq(value);
       });
+
+      it('works when the cookie contains a "="', function() {
+        let value = `${randomString()}=${randomString()}`;
+        document.cookie = `${COOKIE_NAME}=${value};`;
+        let afterRoundtrip = this.subject().read(COOKIE_NAME);
+
+        expect(afterRoundtrip).to.eq(value);
+      });
     });
 
     describe('writing a cookie', function() {
@@ -593,6 +601,14 @@ describe('CookiesService', function() {
 
         expect(this.subject().read()).to.deep.equal({ [COOKIE_NAME]: writtenValue, aRequestCookie: requestValue });
       });
+
+      it('works when the cookie contains a "="', function() {
+        let value = `${randomString()}=${randomString()}`;
+        this.subject().write(COOKIE_NAME, value);
+        let afterRoundtrip = this.subject().read(COOKIE_NAME);
+
+        expect(afterRoundtrip).to.eq(value);
+      });
     });
 
     describe('writing a cookie', function() {