Skip to content

Commit

Permalink
Remove password from Server object
Browse files Browse the repository at this point in the history
  • Loading branch information
jm-mailosaur committed Apr 14, 2021
1 parent c33de22 commit 2b8179d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions mailosaur/models/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ class Server(object):
:param id: Unique identifier for the server. Used as username for
SMTP/POP3 authentication.
:type id: str
:param password: SMTP/POP3 password.
:type password: str
:param name: A name used to identify the server.
:type name: str
:param users: Users (excluding administrators) who have access to the
Expand All @@ -20,7 +18,6 @@ def __init__(self, data=None):
data = {}

self.id = data.get('id', None)
self.password = data.get('password', None)
self.name = data.get('name', None)
self.users = data.get('users', None)
self.messages = data.get('messages', None)
3 changes: 0 additions & 3 deletions tests/servers_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,13 @@ def test_crud(self):
created_server = self.client.servers.create(options)
self.assertIsNotNone(created_server.id)
self.assertEqual(server_name, created_server.name)
self.assertIsNotNone(created_server.password)
self.assertIsInstance(created_server.users, list)
self.assertIsInstance(created_server.messages, numbers.Number)

# Retrieve a server and confirm it has expected content
retrieved_server = self.client.servers.get(created_server.id)
self.assertEqual(created_server.id, retrieved_server.id)
self.assertEqual(created_server.name, retrieved_server.name)
self.assertIsNotNone(retrieved_server.password)
self.assertIsInstance(retrieved_server.users, list)
self.assertIsInstance(retrieved_server.messages, numbers.Number)

Expand All @@ -48,7 +46,6 @@ def test_crud(self):
updated_server = self.client.servers.update(retrieved_server.id, retrieved_server)
self.assertEqual(retrieved_server.id, updated_server.id)
self.assertEqual(retrieved_server.name, updated_server.name)
self.assertEqual(retrieved_server.password, updated_server.password)
self.assertEqual(retrieved_server.users, updated_server.users)
self.assertEqual(retrieved_server.messages, updated_server.messages)

Expand Down

0 comments on commit 2b8179d

Please sign in to comment.