mxresolv.Lookup() now properly randomized hosts in some situations #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
mxresolv.Lookup()
was not properly randomzing MX hosts returned in some situations.Implementation
mxresolv.SetDeterministic()
to improve the quality of testingmockdns
for lookups instead of relying on actual DNS records on the internet.r := rand.New(rand.NewSource())
instead of the global source in the rand package.rand.New()
call.mxresolv
as it complained I was usingmath/rand
instead ofcrypto/rand