SUP-15: fix_leading_dot() cuts in the middle of a quoted character #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrawn01
force-pushed
the
thrawn/develop
branch
from
44ad472
to
1c02fd1
Compare
…dle of a quoted character
thrawn01
force-pushed
the
thrawn/develop
branch
from
1c02fd1
to
2b98a64
Compare
b0d0nne11
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
quoted-printable fix_leading_dot() no longer cuts the line in the middle of a quoted character. This caused random unicode encoding issues when sending emails that had a specific case where the new line started with a '.' but also ended on a quoted character.
Implementation
Discovered
quopri.ishex()is not identifying hex characters properly if the provided string had more than 1 character.