Expose __version__ module-level attribute #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for integrators to need to check the flanker version being run by the client in order to enable/disable flanker functionality depending on which python version is being run. Indeed, if the python version is 2.x, any version of flanker should work, however if the version is 3.x, only flanker versions >= 0.9 are compatible. This patch makes flanker comply with PEP396 [1] and allows for runtime version checking in cases where a hard dependency requiring flanker >= 0.9 is not possible (e.g. optional e-mail validation) [1] https://www.python.org/dev/peps/pep-0396/#specification
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for integrators to need to check the flanker version
being run by the client in order to enable/disable flanker
functionality depending on which python version is being run.
Indeed, if the python version is 2.x, any version of flanker should
work, however if the version is 3.x, only flanker versions >= 0.9 are
compatible.
This patch makes flanker comply with PEP396 [1] and allows for runtime
version checking in cases where a hard dependency requiring flanker >=
0.9 is not possible (e.g. optional e-mail validation)
[1] https://www.python.org/dev/peps/pep-0396/#specification