Make addresslib Python 3 compatible #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is amazing news. Is there a sense of when Python 3 support may be released? |
|
@pudo I am working on it. Although we at Mailgun do not use Python 3, so this is a side project for me. @b0d0nne11 could you please take a look at the changes. |
|
If flanker now has full python 3 compatibility, would it be possible to possible to push a new release to PyPi such that it can be easily installed via pip? |
|
@JamesMcGuigan unfortunately Flanker does not have full Python 3 compatibility yet. Only a limited set of packages is Python 3 compatible. I have not been able to continue the work due to lack of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes flanker/addresslib Python 3 compatible.
The current functionality when running in Python 2 is not changed. In Python 3 we expect text inputs (str) and all methods that return string types (str/unicode) in Python 2 are returning str unconditionally.
The only problem that I have not yet fixed is that ASCII separator symbols
0x1c, 0x1d, 0x1e, 0x1ffor some reason became allowed in the display name in Python 3.