Change default charset when decoding mime parts #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can safely decode text mime parts with utf-8 instead of ascii because ascii is just a subset of utf-8
|
Can one of the admins verify this patch? |
|
As a side note: decoding text mime parts with ascii can become a problem if it contains unicode information. I have first hand experience with this because I had an email attachment that contained unicode but was decoded using ascii and therefore wasn't properly readable. |
|
This sounds reasonable but can you add a test for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can safely decode text mime parts with utf-8 instead of ascii because ascii is just a subset of utf-8