Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LABEL in Dockerfile, should be key=value #5990

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix LABEL in Dockerfile, should be key=value #5990

merged 1 commit into from
Aug 7, 2024

Conversation

h3ssan
Copy link
Member

@h3ssan h3ssan commented Aug 6, 2024

Modified Files

  • data/Dockerfiles/acme/Dockerfile
  • data/Dockerfiles/backup/Dockerfile
  • data/Dockerfiles/clamd/Dockerfile
  • data/Dockerfiles/dockerapi/Dockerfile
  • data/Dockerfiles/dovecot/Dockerfile
  • data/Dockerfiles/netfilter/Dockerfile
  • data/Dockerfiles/olefy/Dockerfile
  • data/Dockerfiles/phpfpm/Dockerfile
  • data/Dockerfiles/postfix/Dockerfile
  • data/Dockerfiles/rspamd/Dockerfile
  • data/Dockerfiles/sogo/Dockerfile
  • data/Dockerfiles/solr/Dockerfile
  • data/Dockerfiles/unbound/Dockerfile
  • data/Dockerfiles/watchdog/Dockerfile

Description

Referring to the Official Docker Docs, clearly said the format of LABEL is

LABEL <key>=<value> <key>=<value> <key>=<value> ...

But the mentioned files are written as follows:

LABEL <value>

Also in the resource of Docker Docs, there it said:

The LABEL instruction adds metadata to an image. A LABEL is a key-value pair

Refering to the [Official Docker Docs](`https://docs.docker.com/reference/dockerfile/#label`), clearly said the format of LABEL is `LABEL <key>=<value> <key>=<value> <key>=<value> ...`.
Copy link
Member

@DerLinkman DerLinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@DerLinkman DerLinkman merged commit fd92785 into mailcow:staging Aug 7, 2024
2 checks passed
@h3ssan h3ssan deleted the fix/dockerfile-label-fix branch August 7, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants