Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the settings link on the plugin list screen goes to the new settings page #33

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Ensure the settings link on the plugin list screen goes to the new settings page #33

merged 1 commit into from
Jun 18, 2024

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Jun 18, 2024

Description of the Change

In #29 we changed the location of the plugins settings page. In testing, I found the Settings link that we show on the plugin list view was still pointing to the old location. This PR updates that link.

Closes #32

How to test the Change

  1. Go to wp-admin/plugins.php
  2. Ensure the Mailchimp plugin is active
  3. Click on the Settings link under the Mailchimp plugin
  4. Ensure the proper settings page loads

Changelog Entry

Fixed - Ensure the plugin settings link goes to the right place

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 1.6.0 milestone Jun 18, 2024
@dkotter dkotter requested a review from nateconley June 18, 2024 17:12
@dkotter dkotter self-assigned this Jun 18, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 18, 2024
nateconley
nateconley approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@nateconley nateconley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you

@dkotter dkotter merged commit 2764c18 into develop Jun 18, 2024
4 checks passed
@dkotter dkotter deleted the fix/plugin-link branch June 18, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateconley nateconley nateconley approved these changes

Assignees

@dkotter dkotter

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Ensure the Settings link on the plugin list screen goes to the new top-level settings menu
2 participants
@dkotter @nateconley