Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another php8.1 upgrade #2418

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Another php8.1 upgrade #2418

wants to merge 3 commits into from

Conversation

matidau
Copy link
Contributor

@matidau matidau commented Aug 5, 2024

This is my take on upgrading to PHP 8.1 with the feedback from @kiekerjan's PR #2309.

Would probably like to move the PHP Version from the if on line 94 in nextcloud.sh and make it an additional mandatory argument for the InstallNextcloud() function. But to keep this PR simple initially I have foregone that.

I have tested this with upgrading from a v57a backup (nextcloud 20.0.14) successfully.

@binarykitchen
Copy link
Contributor

Just double-checking, there are no backward incompatible changes between v8.0 and v8.1 in our repo?
https://www.php.net/manual/en/migration81.incompatible.php

@binarykitchen
Copy link
Contributor

+1 from me

@matidau
Copy link
Contributor Author

matidau commented Aug 10, 2024

Just double-checking, there are no backward incompatible changes between v8.0 and v8.1 in our repo? https://www.php.net/manual/en/migration81.incompatible.php

These are covered in the individual packages.

Roundcube 1.6 introduced PHP 8.1 and is backwards compatible with 8.0.

Z-Push 2.7.1 Fixed the only PHP 8.1 specific issue that has been come across. There is still PHP 8.0 errors coming up and being fixed though. 2.7.4 has some more of these. Z-Push will be aiming to maintain PHP 7.4 to latest PHP.

I don't think there are any problems with moving to 8.1.

@binarykitchen
Copy link
Contributor

Great, thanks. Will leave it to @JoshData to review + merge, then I will do the next part, the NC upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants