Optimizations, a bug, and visibility functions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 9, 2013 11:30
…ublications if there are huge amounts of non-public publications; meaning that only public publications are ordered by the sql server instead of all and including non-public publications)
(using code and logic as found elsewhere in Aigaion)
(importing put abstract string in note field and vice versa)
query optimized for huge limit counts (as with paginated pages), e.g limit 10000, 25 actually retrieves 10025 rows, then dumps the first 10000 the logic behind the optimization is to eliminate the amount of data of the rows to be dumped anyways.
TODO: getPubStructForTopic could be optimized the same way; this hasn't been done to preserve upstream compatibility
…ctionality given in libraries/publication_db.php->getVisibleCountForTopic()
|
|
||
| if ($userlogin->isAnonymous()) //get only public keywords | ||
| { | ||
| $Q = $CI->db->query("SELECT ".AIGAION_DB_PREFIX."keywords.* FROM ".AIGAION_DB_PREFIX."keywords, ".AIGAION_DB_PREFIX."publicationkeywordlink, ".AIGAION_DB_PREFIX."publication |
There was a problem hiding this comment.
This seems to be wrong, what's the purpose of having the publication table here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I hope I don't create a mess. I tried to keep everything capsulated in separate commits. Please review the commits.