perf(tokio): switch to rt-multi-thread for better concurrency #2842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generally the performance when spawning would improve by using the
rt-multi-thread
feature overrt
.These have been switched for
ant-node
andant-networking
that were assumed to be in most need of it.This change may or may not have deeper and wider consequences including solving, unveiling or give rise to bugs, or otherwise affect functionality in unintended ways, as the system has been built relying on single-threaded tokio runtime.
I would say this change requires thorough validation in test environment to make sure all such unintended consequences are identified.
Related Issue
Fixes #2841.
Notes
I have not added tests that prove the fix is effective or does not break anything.
I have not verified in a test network that the fix is effective or does not break anything.
I did not find a branch
alpha
to make the PR to, as requested inREADME
, and went formain
instead, as it seemed most suitable.