Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(tokio): switch to rt-multi-thread for better concurrency #2842

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gnytezero
Copy link

@gnytezero gnytezero commented Mar 16, 2025

Description

Generally the performance when spawning would improve by using the rt-multi-thread feature over rt.
These have been switched for ant-node and ant-networking that were assumed to be in most need of it.

This change may or may not have deeper and wider consequences including solving, unveiling or give rise to bugs, or otherwise affect functionality in unintended ways, as the system has been built relying on single-threaded tokio runtime.

I would say this change requires thorough validation in test environment to make sure all such unintended consequences are identified.

Related Issue

Fixes #2841.

Notes

I have not added tests that prove the fix is effective or does not break anything.
I have not verified in a test network that the fix is effective or does not break anything.

I did not find a branch alpha to make the PR to, as requested in README, and went for main instead, as it seemed most suitable.

@gnytezero
Copy link
Author

gnytezero commented Mar 16, 2025

I realized this needs additional work, as record_store::tests::can_store_after_restart fails when running all tests together, even though it passes when run separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not using multi-thread tokio runtime.
1 participant