Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat nodejs napi rs bindings #2821

Merged
merged 26 commits into from
Mar 24, 2025
Merged

Conversation

b-zee
Copy link
Contributor

@b-zee b-zee commented Mar 7, 2025

  • feat: implement basic NodeJS bindings with napi-rs
  • fix: format; release profile removal in crate

@b-zee b-zee marked this pull request as ready for review March 18, 2025 16:10
@b-zee b-zee force-pushed the feat-nodejs-napi-rs-bindings branch from 671f9e0 to 51775e4 Compare March 19, 2025 06:56
Copy link
Member

@grumbach grumbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Benno! 👏

@vphongph
Copy link
Contributor

Looks great! GG!

To sum up:
90% (60/66) coverage of the functions from Rust!!

4 are referenced in the docs/comments as ToDo:

  • upload_chunks_with_retries()
  • get_raw_quotes()
  • get_store_quotes()
  • init_with_config()

2 are not referenced in the docs/comments:

  • enable_client_events()
  • get_quotes_for_content_addresses(), but this one is from external signer, it's low priority as Anselme told me

@b-zee b-zee added this pull request to the merge queue Mar 24, 2025
Merged via the queue into maidsafe:main with commit 533ec25 Mar 24, 2025
25 checks passed
@b-zee b-zee deleted the feat-nodejs-napi-rs-bindings branch March 24, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants