Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rpc in antctl with metric service #2670

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace rpc in antctl with metric service #2670

wants to merge 2 commits into from

Conversation

ermineJose
Copy link
Contributor

@ermineJose ermineJose commented Jan 25, 2025 •
edited
Loading

Description

ant-node-manager currently uses rpc server to collect node_information and network_information, replace the rpc server with metric server.

Related Issue

Fixes #<issue_number> (if applicable).

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch from 3786eb7 to cb994a9 Compare January 28, 2025 15:55
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 28, 2025
View reviewed changes
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 2 times, most recently from b0761aa to 35433fc Compare January 28, 2025 16:53
RolandSherwin
RolandSherwin reviewed Jan 30, 2025
View reviewed changes
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 5 times, most recently from 7f6233c to d7e2457 Compare February 2, 2025 17:54
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2025
View reviewed changes
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 4 times, most recently from f884154 to 405c596 Compare February 3, 2025 06:11
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 2 times, most recently from c3851ea to c92f726 Compare February 5, 2025 07:21
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 2 times, most recently from 8b1b43f to 41e2acc Compare February 14, 2025 09:57
@ermineJose ermineJose marked this pull request as ready for review February 14, 2025 09:58
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 14, 2025
View reviewed changes
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch from 41e2acc to c7ab0bf Compare February 14, 2025 10:05
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 4 times, most recently from 5488501 to 262d7b0 Compare February 18, 2025 18:08
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch from 262d7b0 to ee9994a Compare February 24, 2025 08:43
@ermineJose ermineJose changed the title Drop rpc replace metrics Replace rpc in antctl with metric service Feb 25, 2025
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 2 times, most recently from b9a531e to b65355e Compare February 27, 2025 07:24
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 7 times, most recently from 0d8b7c5 to d5ff776 Compare March 20, 2025 18:49
@ermineJose
feat: replace metric_service with rpc in antctl
00e9e1d 
BREAKING CHANGE

fix: add proper error handling to metric service support

feat: add proper listeners fetching support

feat: remove connected_peer display from antctl temporarily

feat: add set root_dir method to NetworkBuilder

feat: remove connected_peer support from metrics server temporarily

feat: pass root_dir as variable to metric server

feat: replace RpcActions with MetricActions

fix: fix typos

fix: support metric client with local tests

feat: refactor antctl tests with metric service

feat: remove rpc from antctl and service

refactor: remove rpc_soc_addr instances

refactor: make rpc_soc_address as optional and remove other rpc instances

test: refactor antctl tests to remove rpc

refactor: add proper formatting

fix: listener_addr issue in network_info

fix: rebase to initial peers and other root dir changes
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch 3 times, most recently from f65e6d8 to a4cfe15 Compare March 20, 2025 19:02
@ermineJose ermineJose force-pushed the drop-Rpc-replace-Metrics branch from a4cfe15 to 85ee105 Compare March 20, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacderida jacderida jacderida left review comments

@RolandSherwin RolandSherwin RolandSherwin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ermineJose @jacderida @RolandSherwin