Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

Build failure with rust nightly #149

Closed
chandraprakash opened this issue Jun 19, 2015 · 3 comments
Closed

Build failure with rust nightly #149

chandraprakash opened this issue Jun 19, 2015 · 3 comments
Assignees

Comments

@chandraprakash
Copy link
Contributor

rustc 1.2.0-nightly (2f5683913 2015-06-18)

@vinipsmaker
Copy link
Contributor

This recent build failures comes from two sources:

@chandraprakash
Copy link
Contributor Author

+1 .. Thanks Vinícius

@vinipsmaker
Copy link
Contributor

Previously, join couldn't fail, but outside of the scoped API, this scenario might happen.

I couldn't easily convert Err(Box<Any + Send + 'static>) to Err(std::io::Error), so I used unwrap for now. Possibly I'll refactor to use some adapter (e.g. Err(Error::new(Other, /* ... */)) or change BroadcastAcceptor::accept return type. These solutions touch public interface and I would need some time to make sure I don't break anything, but I was told you guys are in a hurry to getting this thing building for now, so I used unwrap.

vinipsmaker added a commit to vinipsmaker/crust that referenced this issue Jun 19, 2015
The build failures comes mainly due to deprecation of thread::scoped.

Fixes maidsafe-archive#149
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants