Bugfix forestry prices and trade cost #781
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐦 Description of this PR 🐦
In the current develop, we observe huge negative prices for wood in CHA in 2070, and huge costs for trade in 2070 in other regions. The reason for this is that we enfore harvest of timber plantations at rotation age. In the specific case above, this creates a conflict with equation
q21_trade_reg_up
. Put simply, enforced wood production from timber plantations is higher than allowed byq21_trade_reg_up
, which results in negative prices.This PR resolves this issues by allowing for more flexibility in harvest from timber plantations. Timber plantation harvest is no longer enforced at rotation age to avoid conflicts with `q21_trade_reg_up.
In addition, cost for additional imports to maintain feasibility are reduced from 12300 to 1500 USD17MER per tDM to avoid implausibly high costs and prices for wood and woodfuel
Changelog:
q21_trade_reg_up
, which can result in huge costs and negative prices for wood. To ensure that harvest from timber plantations is prioritized over harvest from natural forest,s32_harvesting_cost
is set to 50% ofs35_timber_harvest_cost_secdforest
.vm_supply
corrected in macrom21_baseline_production
🔧 Checklist for PR creator 🔧
Label pull request from the label list.
Self-review own code
magpie4
R library has been updated accordingly and backwards compatible where necessary.scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)Document changes
CHANGELOG.md
goxygen::goxygen()
and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"
Rscript start.R --> "test runs"
Rscript start.R --> "test runs"
📉 Performance changes 📈
🚨 Checklist for reviewer 🚨
CHANGELOG
is updated correctly