[Android] Using a well-formed IETF language tags instead of debug string #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description
This PR replaces all
Locale#toString()
withLocale#toLanguageTag()
for Android 5.0 and above.Reason for changes
The plugin returns a debug string instead of a locale tag. For example, instead of
zh_Hant_TW
(lang_script_country
) we gotzh_TW_#Hant
(lang_country_#script
). This is contrary to the Dart locale tag format. Dart and intl package uses IETF BCP 47 format and IANA Language Subtag Registry to determine locale: https://api.flutter.dev/flutter/dart-ui/Locale-class.html.When passing a string like
zh_TW_#Hant
instead ofzh_Hant_TW
to the intl.Locale.parse we got aFormatException
.The documentation for Android
Locale#toString()
says:instead of it, the
Locale#toLanguageTag()
says: