Do not overwrite previously generated value

[VincentBean]

This PR fixes an issue where a value that was generated previously will always be overwritten by the getCondition method because it retrieves the data directly from the product.

For example, when the manage_stock attribute is selected it will use getAttributeValue and getManageStockValue to retrieve the correct value. But when use_config_manage_stock is enabled on a product it should not listen to the product's value, which is what getManageStockValue does.
But because Helper/Source.php:632 defines conditions for manage_stock the getCondition will run which retrieves the value directly from the product and not the default configuration.

This can be reproduced by setting manage_stock to false and use_config_manage_stock to true on a product and true in the global configuration.

As I am not completely familiar with this module I am unsure what the impact is of this change and if this is the best solution.

[Marvin-Magmodules]

Hi @VincentBean,

Thank you for raising this detailed issue. Everything is clear, but I’m having difficulty reproducing the behavior. When setting the global configuration to “use stock,” it doesn’t allow me to configure the product’s “manage stock” and “use config” settings as described through the Magento admin panel.

That said, this PR does make sense in different scenarios, so we’ll include it in the upcoming release scheduled for early January.

Thank you for your contribution!

[VincentBean]

Thanks for the reply!

The Magento interface does not let you set it when the checkbox is checked. When you have manage stock enabled globally you can:

1. Uncheck the use default checkbox on the product
2. Disable manage stock on the product
3. Check the use default checkbox on the product

After that you should be able to reproduce. In the database it should have set manage_stock to 0 and the use_config_manage_stock value to 1 at the product row.

[Marvin-Magmodules]

@VincentBean, thank you for the clarification—it’s very helpful! I’ll test this flow as part of the upcoming release scheduled for early January.