Typo in 3 participant channel figure #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `G''` and `G'` funded `B`, leaving `C` unfunded in the virtual channel. `G''` now funds `C`.
|
The latter of the two highlighted destinations is changed to
|
geoknee
requested changes
May 6, 2021
There was a problem hiding this comment.
Hey @BlakeMScurr thanks for spotting this! Your change looks good -- but I'd like to update main.pdf file as well as the source file changes. Are you able to do that? If not, I can do it.
I'm setting up an automated test for this #7 .
Merge upstream
|
@geoknee no problem, I regenerated main.pdf and it looks good to me. I checked it through an online tool https://www.diffchecker.com/pdf-diff/ and the only differences were my changes and yours that you recently merged. (the first "build paper" commit was me not using bibtex 😅) |
geoknee
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
G''andG'fundedB, leavingCunfunded in the virtual channel.G''now fundsC.