add: ID for icon cloud to avoid hydration errors #473
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Icon Cloud component in an SSR framework such as NextJS, the default behaviour of the upstream react-icon-cloud dependency is to use a UUID for the canvas ID. This is a problem, as the UUID will change between the server and the client and cause a hydration error. Since the upstream dependency also allows for changing the ID with the
id
prop, I think that having that filled as the default for this component and therefore alleviating the issue above will be better, as it is safe to assume that most users of MagicUI will most likey be using some kind of SSR framework.