fix: prevent URI encoding #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for you contribution. Will merge this! |
|
🚀 PR was released in |
|
i have again this issuer not fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
The API doesn't seem to decode query parameters on its end; that said, encoding it here in the SDK will lead to a bad interpretation of the request URL and therefore the lack of the
issuerquery param.Note: an alternative solution would be decoding URIs in the API so we could leave this code untouched; however, I believe doing so in the SDK would cause fewer side effects.
✅ Fixed Issues
🚨 Test instructions
#68
patch:v1.3.1