Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mint module for minting NFTs #105

Conversation

bengriffin1
Copy link
Contributor

@bengriffin1 bengriffin1 commented Mar 20, 2023

πŸ“¦ Pull Request

Adding a feature for NFT Minting + Delivery. Adds a new "Mint" module with 2 functions, for both ERC721 and ERC1155 minting.

βœ… Fixed Issues

None

🚨 Test instructions

yarn run test

⚠️ Don't forget to add a semver label!

minor

@justinnout justinnout added the minor Increment the minor version when merged label Mar 20, 2023
Copy link
Contributor

@justinnout justinnout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits

CHANGELOG.md Outdated Show resolved Hide resolved
src/core/sdk-exceptions.ts Outdated Show resolved Hide resolved
test/spec/modules/mint/mint721.spec.ts Outdated Show resolved Hide resolved
test/spec/modules/mint/mint1155.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@justinnout justinnout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinnout justinnout merged commit 1bfe265 into magiclabs:master Mar 22, 2023
@magiclabsFE
Copy link

πŸš€ PR was released in v1.9.0 πŸš€

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants