Regenerating project client #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`yarn codegen`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stigi
commented
Nov 22, 2024
Comment on lines
+1
to
+5
| --- | ||
| '@magicbell/project-client': patch | ||
| --- | ||
|
|
||
| Correctly flagging nullable properties. All of them were optional before so they are likely handled correctly already and this is just affecting response validation. |
There was a problem hiding this comment.
@smeijer do you agree that this is a patch?
@magicbell/cli
@magicbell/embeddable
@magicbell/core
@magicbell/in-app
magicbell
@magicbell/project-client
@magicbell/magicbell-react
@magicbell/react-headless
@magicbell/user-client
@magicbell/webpush
commit: |
smeijer
approved these changes
Nov 22, 2024
|
I've tested the preview build ( |
Merged
stigi
pushed a commit
that referenced
this pull request
Nov 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @magicbell/project-client@0.5.4 ### Patch Changes - [#433](#433) [`d0f7bae`](d0f7bae) Thanks [@stigi](https://github.com/stigi)! - Correctly flagging nullable properties. All of them were optional before so they are likely handled correctly already and this is just affecting response validation. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the schema changes to correctly flag
nullableproperties (https://github.com/magicbell/magicbell/pull/5419).The API responses did not change, and this just fixes schema validation that was previously throwing errors e.g. when a tokens
discarded_atwasnull.