Skip to content

Commit

Permalink
test(ingest): limit GMS retries in test (datahub-project#5509)
Browse files Browse the repository at this point in the history
  • Loading branch information
hsheth2 authored and maggiehays committed Aug 1, 2022
1 parent 27274d3 commit 3d0d648
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 10 deletions.
5 changes: 4 additions & 1 deletion metadata-ingestion/src/datahub/emitter/rest_emitter.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import functools
import json
import logging
import os
from json.decoder import JSONDecodeError
from typing import Any, Dict, List, Optional, Tuple, Union

Expand Down Expand Up @@ -35,7 +36,9 @@ class DataHubRestEmitter:
504,
]
DEFAULT_RETRY_METHODS = ["HEAD", "GET", "POST", "PUT", "DELETE", "OPTIONS", "TRACE"]
DEFAULT_RETRY_MAX_TIMES = 3
DEFAULT_RETRY_MAX_TIMES = int(
os.getenv("DATAHUB_REST_EMITTER_DEFAULT_RETRY_MAX_TIMES", "3")
)

_gms_server: str
_token: Optional[str]
Expand Down
24 changes: 15 additions & 9 deletions metadata-ingestion/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,28 @@

import pytest

from tests.test_helpers.docker_helpers import docker_compose_runner # noqa: F401
from tests.test_helpers.state_helpers import mock_datahub_graph # noqa: F401
# Enable debug logging.
logging.getLogger().setLevel(logging.DEBUG)
os.environ["DATAHUB_DEBUG"] = "1"

# Disable telemetry
os.environ["DATAHUB_TELEMETRY_ENABLED"] = "false"

# Reduce retries on GMS, because this causes tests to hang while sleeping
# between retries.
os.environ["DATAHUB_REST_EMITTER_DEFAULT_RETRY_MAX_TIMES"] = "1"

# We need our imports to go below the os.environ updates, since mere act
# of importing some datahub modules will load env variables.
from tests.test_helpers.docker_helpers import docker_compose_runner # noqa: F401,E402
from tests.test_helpers.state_helpers import mock_datahub_graph # noqa: F401,E402

try:
# See https://github.com/spulec/freezegun/issues/98#issuecomment-590553475.
import pandas # noqa: F401
except ImportError:
pass

# Enable debug logging.
logging.getLogger().setLevel(logging.DEBUG)
os.putenv("DATAHUB_DEBUG", "1")

# Disable telemetry
os.putenv("DATAHUB_TELEMETRY_ENABLED", "false")


@pytest.fixture
def mock_time(monkeypatch):
Expand Down

0 comments on commit 3d0d648

Please sign in to comment.