Allows Global ReCAPTCHA #288 #289
Conversation
thomas-kl1
force-pushed
the
develop
branch
11 times, most recently
from
f5ff14c to
282463a
Compare
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
thomas-kl1
force-pushed
the
develop
branch
2 times, most recently
from
0ea7822 to
51ed91c
Compare
|
@magento run all tests |
|
hi @nathanjosiah could you take a look on my comments? |
|
poke @nathanjosiah |
|
@thomas-kl1 Apologies for the delay, I am on paternity leave but I left a comment and resolved some existing ones. |
|
@nathanjosiah ho! Congrats! 🎊 🎊 |
|
@magento run all tests |
|
The failures in tests does not seems to be related to this PR. |
|
Connected to #288 |
|
@thomas-kl1 can you merge develop and rerun builds? |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@thomas-kl1 Something appears to be broken with MFTF test generation. The error log indicates it is unable to generate at least one of the tests. Can you check that you are able to build locally? |
|
Hi @nathanjosiah Would be easier for me if you could actually give the result of mftf.log, it's really hard to run test locally with the complete suite.. |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run Functional Tests CE against 2.4.3-develop |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@thomas-kl1 Looks like there are some errors in certain scenarios in the latest build (see https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/security-package/pull/289/bf46e4fe54b374d1b9fcff72e9c97fce/Functional/allure-report-ce/index.html#categories/bda2d1d522cd5c6d3b119ea9eba8bd02/6f6a43bc714a93f9/) specifically |
|
@thomas-kl1 Pinging again for visibility. |
|
Hi @nathanjosiah I'll rebase and take a look when I'll have some free time, sorry for the delay |
|
No worries. I wanted to make sure you saw my comment and that you were
still wanting to work on this issue
|
|
Closing due to inactivity. |
|
Rly? Make it draft but don't close it |
Add the alternative domain https://www.recaptcha.net/recaptcha/api.js
Description (*)
As a merchant I want to select the captcha domain:
https://www.google.com/recaptcha/api.js
https://www.recaptcha.net/recaptcha/api.js
See Google Documentation: https://developers.google.com/recaptcha/docs/faq#can-i-use-recaptcha-globally
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Beside that the PR aims to fix components dependencies declaration.
This PR also add return type hint when possible to method signatures.
Contribution checklist (*)