Fixed camel case issue with resource validation for backend menu items #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing because the contribution has been accepted in #79. |
magento-team
pushed a commit
that referenced
this pull request
Feb 20, 2015
[Extensibility] Sprint 45 CE
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 1, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 1, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 13, 2018
Fix Calls to count()
ghost
mentioned this pull request
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 12, 2019
Merging changes from MC-20336 to MC-19451 branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the regex that handles the validation of backend menu items. I discovered an issue with this when converting some 1.x modules to Magento 2.
I reported this issue on the Magento 2 repo: #79
Ultimately, while you can have camel cased package names for your module directories, when you setup menu item resources, the validation did not allow it. This fix should take care of that.