Empty resolvedScopeCodes when config cache is cleaned #9061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also empty resolvedScopeCodes when config cache is cleaned.
Description
During setup:upgrade we change the name of the default store; magento will clean the config cache as part of saving the store view. However, ScopeCodeResolver's resolvedScopeCodes is not emptied, which means that it still maps 'stores',null to 'default', not the new name of the default store. This will break access to configurations.
Manual testing scenarios
With
/** @var \Magento\Store\Api\Data\WebsiteInterface */
protected $website;
we do
$this->website->getDefault();
$this->website->setCode($siteData['website']['code']);
$this->website->setName($siteData['website']['name']);
$this->website->setSortOrder($siteData['website']['sort_order']);
$this->website->setId(1);
$this->website->save();
Contribution checklist