Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect schema definition for price #8132

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Fix incorrect schema definition for price #8132

merged 1 commit into from
Feb 27, 2017

Conversation

unfunco
Copy link
Member

@unfunco unfunco commented Jan 13, 2017

Fixes an incorrect schema definition for pricing, before this change
the structured data testing tool provided by Google flags the price
as a warning since it contains the currency symbol, a separate
itemprop exists for the priceCurrency, I have added a separate meta
tag for the price without the currenccy symbol.

Fixes an incorrect schema definition for pricing, before this change
the structured data testing tool provided by Google flags the price
as a warning since it contains the currency symbol, a separate
itemprop exists for the priceCurrency, I have added a separate meta
tag for the price without the currenccy symbol.
@avoelkl avoelkl self-assigned this Feb 27, 2017
@avoelkl avoelkl added this to the February 2017 milestone Feb 27, 2017
@magento-team magento-team merged commit 16c0741 into magento:develop Feb 27, 2017
@okorshenko
Copy link
Contributor

@unfunco Thank you for your contribution!
@avoelkl thank you for processing this PR!

@woosley-mg
Copy link

Love this! Thanks @avoelkl

@unfunco unfunco deleted the fix/incorrect-offer-schema-definition branch February 28, 2017 17:11
@Amex68
Copy link

Amex68 commented Nov 6, 2017

I was wondering why this fix does not automatically round up the final price in itemprop="price" like magento does?
structured-data test gives this result.
price 185.130001
priceCurrency EUR

Do you have a solution to this issue?

@Ctucker9233
Copy link

Still not included in 2.1.10

@avoelkl
Copy link
Contributor

avoelkl commented Nov 11, 2017

Feel free to open a github issue or create a PR for this @Amex68 @Ctucker9233 (just one issue, please ;) ). Thanks!

@Amex68
Copy link

Amex68 commented Nov 11, 2017

<meta itemprop="price" content="<?php /* @escapeNotVerified */ echo number_format($block->getDisplayValue(), 2, '.', ','); ?>" />

i found a temporary solution to my problem by adding number_format() function to meta price itemprop. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants