Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed german translation "Warenkorbrn" #747

Closed
wants to merge 1 commit into from
Closed

Fixed german translation "Warenkorbrn" #747

wants to merge 1 commit into from

Conversation

cmuench
Copy link
Contributor

@cmuench cmuench commented Nov 17, 2014

"Warenkorbrn" is not really a german word. I corrected the translation. This phrase is also wrong in all Magento 1.x versions.

@cmuench
Fixed german translation "Warenkorbrn"
899a163 
"Warenkorbrn" is not really a german word. I corrected the translation. This phrase is also wrong in all Magento 1.x versions.
@ooxi
Copy link

ooxi commented Nov 18, 2014

👍

1 similar comment
@ghost
Copy link

ghost commented Nov 18, 2014

👍

@verklov verklov self-assigned this Dec 9, 2014
@avoelkl
Copy link
Contributor

avoelkl commented Dec 19, 2014

nice 👍

@airbone42
Copy link

finally 👍

@benmarks
Copy link
Contributor

No, Warenkorbrn are real, one's for sale where I live http://charleston.craigslist.org/fuo/4818576148.html (coincidentally).

But really, I'm wondering about shipping anything but en_US (the i18n base) with Magento 2. Thoughts?

@maksek
Copy link
Contributor

maksek commented Dec 26, 2014

Hi @cmuench, thanks for PR, it is great when community help with translations. Can you please resubmit your PR int develop branch, so we can accept it?

@maksek maksek assigned maksek and unassigned verklov Dec 26, 2014
@cmuench cmuench closed this Dec 26, 2014
@cmuench
Copy link
Contributor Author

cmuench commented Dec 26, 2014

New PR #876

magento-engcom-team added a commit that referenced this pull request Jul 11, 2019
@magento-engcom-team
ENGCOM-5372: Fix for config variant stock 736 #747
67a49dd 
 - Merge Pull Request magento/graphql-ce#747 from limesharp/graphql-ce:fix-for-config-variant-stock-736
 - Merged commits:
   1. b161142
   2. f29c407
   3. c8b6de6
   4. cb782c8
   5. 3938918
   6. 78c40ee
   7. d90b1b9
   8. b3a9bcf
   9. f69c8e8
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2019
@naydav
ENGCOM-5372: Fix for config variant stock 736 #747
85fe37f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maksek maksek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cmuench @ooxi @avoelkl @airbone42 @benmarks @maksek @verklov