Is Allowed Guest Checkout

[hungvt]

This code affect to the result of is_allowed. It's alway true even i set it to false from a custom module.

[vrann]

@hungvt This is a good fix. Due to the mutability of the data passed to the events, initial code wiped out the data generated in other observers and broke the consistency of the flow.

[vrann]

@hungvt There are couple of tests to fix:

There were 3 failures:
1) Magento\Downloadable\Test\Unit\Observer\IsAllowedGuestCheckoutObserverTest::testIsAllowedGuestCheckoutConfigSetToTrue with data set #1 ('downloadable', true)
Expectation failed for method name is equal to <string:setIsAllowed> when invoked at sequence index 0
Parameter 0 for invocation Magento\Framework\DataObject::setIsAllowed(false) does not match expected value.
Failed asserting that false matches expected true.
/home/travis/build/magento/magento2/app/code/Magento/Downloadable/Observer/IsAllowedGuestCheckoutObserver.php:61
/home/travis/build/magento/magento2/app/code/Magento/Downloadable/Test/Unit/Observer/IsAllowedGuestCheckoutObserverTest.php:158
2) Magento\Downloadable\Test\Unit\Observer\IsAllowedGuestCheckoutObserverTest::testIsAllowedGuestCheckoutConfigSetToTrue with data set #2 ('unknown', false)
Expectation failed for method name is equal to <string:setIsAllowed> when invoked at sequence index 0.
The expected invocation at index 0 was never reached.
3) Magento\Downloadable\Test\Unit\Observer\IsAllowedGuestCheckoutObserverTest::testIsAllowedGuestCheckoutConfigSetToFalse
Expectation failed for method name is equal to <string:setIsAllowed> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

Can you please do that?

[magento-team]

@hungvt Thank you for the contribution