-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/xml parser issue #7339
Fix/xml parser issue #7339
Conversation
Good work! |
Thanks |
@dvynograd well done! Thanks! |
if ( | ||
(is_string($content[$node->nodeName]) || !isset($content[$node->nodeName][0])) | ||
|| (is_array($value) && !is_array($content[$node->nodeName][0])) | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be really nice to cover new introduced behavior with unit test.
Class implementation looked scary even before this change and every next fixed use case may break previous fixes if there is no enforcement with automated tests.
@dvynograd thank you for your contribution to Magento 2 project! |
Test case:
Output
After fix