Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elements.xsd #6283

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Update elements.xsd #6283

merged 1 commit into from
Sep 19, 2016

Conversation

aholovan
Copy link
Contributor

Looks like 'elementNameType' validator is very strict. I've got an exception in dev mode:
#0 (Magento\Framework\Config\Dom\ValidationException): Element 'block', attribute 'name': [facet 'pattern'] The value '4d072daa2b95b9d3fd3995d2faaf2993' is not accepted by the pattern '[a-zA-Z][a-zA-Z\d-_.]*'.

Line: 645

looks like elementNameType validator is very strict. I've got an exception in dev mode:
#0 (Magento\Framework\Config\Dom\ValidationException): Element 'block', attribute 'name': [facet 'pattern'] The value '4d072daa2b95b9d3fd3995d2faaf2993' is not accepted by the pattern '[a-zA-Z][a-zA-Z\d\-_\.]*'.
Line: 645
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 23, 2016

CLA assistant check
All committers have signed the CLA.

@vkorotun
Copy link
Contributor

Internal ticket: MAGETWO-58367

@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept labels Sep 14, 2016
@mmansoor-magento mmansoor-magento merged commit 1a5ad5b into magento:develop Sep 19, 2016
@ihor-sviziev
Copy link
Contributor

Looks like this code was merged in this commit: 2842e92

@aholovan aholovan deleted the patch-1 branch November 7, 2016 07:18
@Ctucker9233
Copy link

@vkorotun @mmansoorebay will MAGETWO-58367 be included in 2.1.3?

magento-engcom-team pushed a commit that referenced this pull request Oct 28, 2020
[Arrows] MC-38620: Merge release branch into 2.4-develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants