Issue 35901: explode(): Argument #2 () must be of type string, null g… #36115

rogerdz · 2022-09-08T14:52:04Z

…iven

Description (*)

TypeError: explode(): Argument #2 ($string) must be of type string, null given in /var/www/php/folder/vendor/magento/module-config/ViewModel/CountryFilter.php:46

Related Pull Requests

Fixed Issues (if relevant)

Fixes TypeError: explode(): Argument #2 ($string) must be of type string, null given in /var/www/php/folder/vendor/magento/module-config/ViewModel/CountryFilter.php:46 #35901

Manual testing scenarios (*)

Login into Admin Site
Go to Stores->Configuration->General->General
Uncheck "Use system value" European Union Countries, remove all select
Save config

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

… null given

m2-assistant · 2022-09-08T14:52:09Z

Hi @rogerdz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rogerdz · 2022-09-08T14:53:02Z

@magento run all tests

magento-automated-testing · 2022-09-08T14:53:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2022-09-09T06:43:07Z

lib/internal/Magento/Framework/App/Config.php

@@ -132,6 +134,6 @@ public function get($configType, $path = '', $default = null)
            $result = $this->types[$configType]->get($path);
        }

-        return $result !== null ? $result : $default;
+        return $result !== null ? $result : ($default !== null ? $default : '');


I think we can simplify it

Suggested change

return $result !== null ? $result : ($default !== null ? $default : '');

return $result ?? $default ?? '';

Here is an example:
https://3v4l.org/SY8Ys

Cloud you, please also cover this change with a unit test?

@ihor-sviziev I added unit test

rogerdz · 2022-09-10T15:03:32Z

@magento run all tests

magento-automated-testing · 2022-09-10T15:03:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

rogerdz · 2022-09-11T16:35:23Z

@magento run all tests

magento-automated-testing · 2022-09-11T16:35:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

lib/internal/Magento/Framework/App/Config.php

rogerdz · 2022-09-13T08:57:53Z

@magento run all tests

magento-automated-testing · 2022-09-13T08:58:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

rogerdz · 2022-09-14T02:38:34Z

Change return value has a lot of impact so I will close this PR and create a new PR that is easier to fix bug

Issue 35901: explode(): Argument magento#2 () must be of type string,…

b1656cd

… null given

sdzhepa added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Sep 8, 2022

m2-community-project bot added the Progress: pending review label Sep 8, 2022

ihor-sviziev requested changes Sep 9, 2022

View reviewed changes

m2-community-project bot assigned ihor-sviziev Sep 9, 2022

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Sep 9, 2022

ihor-sviziev added Award: bug fix Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Risk: low labels Sep 9, 2022

rogerdz and others added 2 commits September 10, 2022 21:51

Merge branch '2.4-develop' into fix-issue-35901

4a5c4db

add unit test

fe750bd

m2-community-project bot added Progress: review and removed Progress: needs update labels Sep 10, 2022

rogerdz and others added 3 commits September 11, 2022 23:29

Merge branch '2.4-develop' into fix-issue-35901

815222c

update code

fd44d02

fix error

6d21256

ihor-sviziev reviewed Sep 13, 2022

View reviewed changes

lib/internal/Magento/Framework/App/Config.php Outdated Show resolved Hide resolved

ihor-sviziev added the Progress: needs update label Sep 13, 2022

m2-community-project bot removed the Progress: review label Sep 13, 2022

issue 35901: update code

33938ce

m2-community-project bot added Progress: review and removed Progress: needs update labels Sep 13, 2022

rogerdz closed this Sep 14, 2022

m2-community-project bot removed the Progress: review label Sep 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 35901: explode(): Argument #2 () must be of type string, null g… #36115

Issue 35901: explode(): Argument #2 () must be of type string, null g… #36115

rogerdz commented Sep 8, 2022

m2-assistant bot commented Sep 8, 2022

rogerdz commented Sep 8, 2022

magento-automated-testing bot commented Sep 8, 2022

ihor-sviziev Sep 9, 2022 •

edited

Loading

rogerdz Sep 10, 2022

rogerdz commented Sep 10, 2022

magento-automated-testing bot commented Sep 10, 2022

rogerdz commented Sep 11, 2022

magento-automated-testing bot commented Sep 11, 2022

rogerdz commented Sep 13, 2022

magento-automated-testing bot commented Sep 13, 2022

rogerdz commented Sep 14, 2022

	return $result !== null ? $result : ($default !== null ? $default : '');
	return $result ?? $default ?? '';

Issue 35901: explode(): Argument #2 () must be of type string, null g… #36115

Issue 35901: explode(): Argument #2 () must be of type string, null g… #36115

Conversation

rogerdz commented Sep 8, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Sep 8, 2022

rogerdz commented Sep 8, 2022

magento-automated-testing bot commented Sep 8, 2022

ihor-sviziev Sep 9, 2022 • edited Loading

Choose a reason for hiding this comment

rogerdz Sep 10, 2022

Choose a reason for hiding this comment

rogerdz commented Sep 10, 2022

magento-automated-testing bot commented Sep 10, 2022

rogerdz commented Sep 11, 2022

magento-automated-testing bot commented Sep 11, 2022

rogerdz commented Sep 13, 2022

magento-automated-testing bot commented Sep 13, 2022

rogerdz commented Sep 14, 2022

ihor-sviziev Sep 9, 2022 •

edited

Loading