-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: customer account create page does not work #35442
Conversation
Fixes this exception which made the create account page unusable: ``` Exception: Deprecated Functionality: trim(): Passing null to parameter magento#1 ($string) of type string is deprecated in /var/www/vendor/magento/module-customer/Block/Widget/Name.php on line 110 in /var/www/vendor/magento/framework/App/ErrorHandler.php:61 ```
Hi @kolaente. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests CE Functional Tests B2B |
Failed to run the builds. Please try to re-run them later. |
@magento run Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento give me 2.4-develop instance |
Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you. |
Hi @sdzhepa, here is your Magento Instance: https://ca7e3ef9c39fbd74def81a91a5e9412e.instances.magento-community.engineering |
Hello @kolaente Could you please provide more details about use-case(preconditions, steps to reproduce, expected/actual results)? I cannot reproduce it by steps:
Actual Result: Account successfully created. No errors or exceptions that block this flow |
We encountered the problem after upgrading to Magento 2.4.4 and PHP 8.1. Is the test instance running on 8.1? The shop we encountered this in has prefix fields enabled which the review instance does not. |
@magento create issue |
Steps to reproduce has been added over here: #35490 (comment) (it would be appreciated if in the future Adobe staff puts a little bit more effort in trying to understand what the proposed code change does so there is fewer time wasted with going back and forth over here on github - because this happens on a lot of tickets or PR's, not only this one and it's wasting soo much time and energy of your contributors) |
Same question #35985 looking for solutionPreconditions and environment Steps to reproduce
Actual result
|
Edited From After submited account creation
|
This seems to be an issue with me not running |
Description (*)
Fixes this exception which made the create account page unusable:
Related Pull Requests
Fixed Issues (if relevant)
none.
Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: