Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace repetitive actions with Action Groups in AdminCreateSimpleProductZeroPriceTest #32295

Conversation

kate-kyzyma
Copy link
Contributor

@kate-kyzyma kate-kyzyma commented Feb 26, 2021

Description (*)

The test is refactored according to the best practices followed by MFTF.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Run the test in the local environment and verified that it run successfully.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Replace repetitive actions with Action Groups in AdminCreateSimpleProductZeroPriceTest #32377: Replace repetitive actions with Action Groups in AdminCreateSimpleProductZeroPriceTest

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2021

Hi @kate-kyzyma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 26, 2021
@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

1 similar comment
@edenduong
Copy link
Contributor

@magento run all tests

@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 4, 2021
@gabrieldagama
Copy link
Contributor

@magento create issue

@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-8943 has been created to process this Pull Request
✳️ @edenduong, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@edenduong edenduong added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 18, 2021
@engcom-Oscar engcom-Oscar added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Mar 23, 2021
@engcom-Oscar engcom-Oscar added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Apr 22, 2021
@engcom-Foxtrot engcom-Foxtrot added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Apr 22, 2021
@engcom-Foxtrot engcom-Foxtrot removed the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Apr 22, 2021
magento-engcom-team pushed a commit that referenced this pull request Apr 26, 2021
@magento-engcom-team magento-engcom-team merged commit f6d6688 into magento:2.4-develop Apr 26, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2021

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Event: Adobe Summit Hackathon Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Replace repetitive actions with Action Groups in AdminCreateSimpleProductZeroPriceTest
6 participants